fix: use shared modal manager to sync container state #5917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5905
This fix uses a shared
ModalManager
betweenOffcanvas
andModal
in order to sync the container state in the scenario where you can trigger the closing/opening of bothOffcanvas
andModal
at the same time. In the case where theOffcanvas
has thescroll
prop set to true, we use a localModalManager
because the shared one handles overflow styles. I think this should be ok since we don't need to modify the container styles when scroll is true.This also fixes some differences in behavior compared to upstream bootstrap where enforce focus should not be enabled when
scroll
is enabled forOffcanvas
. The user should be able to select text, or focus outside. In addition, clicking outsideOffcanvas
should not close theOffcanvas
whenbackdrop
is false: https://getbootstrap.com/docs/5.0/components/offcanvas/#backdrop