Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardColumns renders a single column #5944

Closed
rkgallaway opened this issue Jul 21, 2021 · 4 comments · Fixed by #6030
Closed

CardColumns renders a single column #5944

rkgallaway opened this issue Jul 21, 2021 · 4 comments · Fixed by #6030

Comments

@rkgallaway
Copy link

rkgallaway commented Jul 21, 2021

The Bug

Result

v2.0.0-beta.4 (using Bootstrap 5.0.2) renders a single column. 20 cards were present, all in one column and regardless of card width. neither mention of change in documentation, nor property(s) necessary to achieve multiple columns. Docs do show an example of a single column, implying a change to CardColumn (singular column) functionality, which if intentional warrants a Component rename and I propose a multiple-column CardColumns option.

Expectation

v1.6.1 (Bootstrap 4.6.0) renders 3 columns by default (possibility: card width possibly a factor for column number). 20 cards were also present, divided between the three columns. Documentation does show an example of 3 columns.

To Reproduce

Steps to reproduce the behavior:

  1. Go to this sandbox
  2. view results
  3. notice bootstrap version "5.0.2"
  4. See error
  5. change bootstrap version to "4.6.0"
  6. See three columns as expected

Screenshots

not working:

image

working:

image

Environment

  • Operating System: [Catalina Version 10.15.7]
  • Browser, Version [Version 91.0.4472.114 (Official Build) (x86_64)]
  • React-Bootstrap Version [v2.0.0-beta.4]
  • have reproduced same results with BigSur and WIndows 10 on student machines (unsure of all version specifics)
@kyletsang
Copy link
Member

Looks like this was removed upstream in favor of a 3rd party component:
twbs/bootstrap#28922
https://getbootstrap.com/docs/5.0/components/card/#masonry

We should remove this component and related docs.

@Durai46
Copy link

Durai46 commented Aug 20, 2021

@kyletsang is this issue has still open?

@kyletsang
Copy link
Member

@Durai46 yes, feel free to take it. Thanks

@ryansrofe
Copy link

ryansrofe commented Sep 7, 2021

Fwiw, the recommended approach to use Masonry does not work out of the box with react. Columns are equal in height to the largest card in the row. See attached. The component should be removed from docs for sure because it was removed from bootstrap but I'm wondering what the alternative is for react-bootstrap users?
Screen Shot 2021-09-07 at 1 28 25 PM
Screen Shot 2021-09-07 at 1 28 41 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants