Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add As Prop in AccordionCollapse Component, Fix Issue: #5659 #5991

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Add As Prop in AccordionCollapse Component, Fix Issue: #5659 #5991

merged 2 commits into from
Aug 24, 2021

Conversation

Amanporwal510
Copy link
Contributor

@Amanporwal510 Amanporwal510 commented Aug 23, 2021 •
edited
Loading

Added As prop in AccordionCollapse Component as mentioned in
#5659 (comment)

@Amanporwal510 Amanporwal510 mentioned this pull request Aug 23, 2021
Closed
@kyletsang
Copy link
Member

Thanks for the PR. Can we also add a test for this?

@Amanporwal510
Copy link
Contributor Author

Amanporwal510 commented Aug 24, 2021 •
edited
Loading

@kyletsang, i have added a test case for AccordionCollapse --"should output h1"
Let me know, if something is wrong.

@kyletsang kyletsang linked an issue Aug 24, 2021 that may be closed by this pull request
Accordion component doesn't work with collapsing specific rows in a table. #5659
Closed
@kyletsang kyletsang merged commit f40439e into react-bootstrap:master Aug 24, 2021
@kyletsang
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accordion component doesn't work with collapsing specific rows in a table.
2 participants
@Amanporwal510 @kyletsang