Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added horizontal animation to Collapse #5993

Merged
merged 6 commits into from
Aug 26, 2021
Merged

Added horizontal animation to Collapse #5993

merged 6 commits into from
Aug 26, 2021

Conversation

nsi319
Copy link
Contributor

@nsi319 nsi319 commented Aug 24, 2021 •
edited
Loading

Fix #5977

  • Added Horizontal Collapse component (width based transition of Collapse)
  • Added tests
  • Added Horizontal Collapse to docs

@nsi319
Copy link
Contributor Author

nsi319 commented Aug 24, 2021

Hi @kyletsang
Should we modify the description of the dimension prop since it accepts width.

Screenshot from 2021-08-24 11-38-32

@kyletsang
Copy link
Member

@nsi319 Yeah let's remove that note about the partial support

@nsi319
Copy link
Contributor Author

nsi319 commented Aug 25, 2021

Hi @kyletsang
I have made the required changes. Do let me know if there's anything else to be added.

@kyletsang kyletsang merged commit c8f0d1d into react-bootstrap:master Aug 26, 2021
@kyletsang
Copy link
Member

Thanks!

@kyletsang kyletsang mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collapse - Horizontal animation
2 participants
@nsi319 @kyletsang