fix(ListGroupItem): fix .active not being set with activeKey #6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kyletsang just curious if we can move this forward or if there is something blocking us? Let me know how I can help. |
kyletsang
force-pushed
the
fix/listgroupitem-active
branch
from
03492ee
to
e7b6b06
Compare
|
Hey @ishields, sorry for the delay. I think we should be good to merge this in. I just rebased and will re-test this later in the day. Will include this as part of RC release later today. |
|
Awesome, thank you! 👍 |
|
Thanks for the review @jquense 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6001