fix(Carousel): fix issue where changing activeIndex won't work
#6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golota60
approved these changes
Mar 9, 2022
Yup slide=false works 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was brought up in #6263
If you set the slides and then change the
activeIndex, it will result in the carousel locking up becauseisSlidingis set to true and RTG'sonEnteredisn't triggered to reset this.Minimal repro:
https://codesandbox.io/s/react-bootstrap-carousel-active-index-forked-xht0f1?file=/src/App.js
Issue appears to be fixed by moving some of the code that handles the rendered active index into a
useEffecthook.Note, I had to tweak the delays of 1 test because the timers seem to be triggering too fast when testing.