Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 compatibility #63

Closed
brentryan opened this issue Apr 10, 2014 · 6 comments
Closed

IE8 compatibility #63

brentryan opened this issue Apr 10, 2014 · 6 comments

Comments

@brentryan
Copy link
Contributor

It looks like this api isn't working in IE8.

SCRIPT1010: Expected identifier
react-bootstrap.js, line 1446 character 20

This happens when we reference a Button like this:

var Button = require('react-bootstrap').Button;

Any ideas on what's required to get this to function in IE8?

@stevoland
Copy link
Contributor

I think this might have already been fixed in v0.8.1. Which version are you on?

@brentryan
Copy link
Contributor Author

that's what I thought might be the case so I updated to v0.8.1 and I'm still seeing the same issues.

@stevoland
Copy link
Contributor

hmm. You're using react-bootstrap.js from https://github.com/react-bootstrap/react-bootstrap-bower ?

@brentryan
Copy link
Contributor Author

I found an issue where my build wasn't cleanly using the v0.2 that had the bug in that wrapper.

However, even after getting the right react-bootstrap.js, I'm now hitting a different error:

SCRIPT1028: Expected identifier, string or number
react-bootstrap.js, line 2204 character 53

which is this code:

  renderLabel: function () {
    return this.props.label ? React.DOM.label( {for:this.props.id}, this.props.label) : null;
  },

@brentryan
Copy link
Contributor Author

I believe I've found the bug and fixed it. Pull request submitted here cvent-archive@3f204f4

@stevoland
Copy link
Contributor

Thanks, fixed in v0.8.2

aryad14 pushed a commit to aryad14/react-bootstrap that referenced this issue Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants