Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Offcanvas): fix children mounting 2x on show when not responsive #6416

Merged
merged 1 commit into from Aug 1, 2022

Conversation

kyletsang
Copy link
Member

Fixes #6411

This is a bit of a hack to revert the regular offcanvas back to 2.4 behavior.

We should fix the behavior so that it follows upstream bootstrap:

  • Do not unmount when not shown (Needs a new prop in @restart/ui Modal)
  • Do no render at body level

@kyletsang kyletsang requested a review from golota60 July 31, 2022 05:36
Copy link
Collaborator

@golota60 golota60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 😄

@kyletsang kyletsang merged commit e2c4eeb into master Aug 1, 2022
@kyletsang kyletsang deleted the fix-offcanvas-mount branch August 1, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.5.0 beta1] Offcanvas body mounted twice
2 participants