fix(DropdownItem): simplify component type #6659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
approved these changes
Jul 15, 2023
|
When running tsc, this issue has been bothering me, and I'm not sure how to resolve it. I was close to looking for other packages. |
|
@kevin82222 the fix is released in 2.9.0-beta.1 if you want to try it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6651
Simplifies
BsPrefixRefForwardingComponent<typeof BaseDropdownItem, DropdownItemProps>toBsPrefixRefForwardingComponent<'a', DropdownItemProps>The
typeof BaseDropdownItemcompiles into an import from@restart/ui/esm/...but that isn't exposed in the package.json exports. I'm not sure how to fix the import path, so this small fix will do for now.