Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FormControl): add size support when using plaintext #6667

Merged
merged 1 commit into from Jul 25, 2023
Merged

fix(FormControl): add size support when using plaintext #6667

merged 1 commit into from Jul 25, 2023

Conversation

marcalexiei
Copy link
Contributor

Currently, when passing plaintext alongside with size prop, the relevant size class is not set in the input.

@marcalexiei
Copy link
Contributor Author

Not sure why codecov fails.
I checked the file on the run and it looks that is tested completely: CodeCov report

kyletsang
kyletsang reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@kyletsang kyletsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to simplify the code further by placing all the class modifiers into the classNames expressions on line 150

@marcalexiei marcalexiei force-pushed the feature/plaintext-size branch 2 times, most recently from 452fea8 to 1dc371e Compare July 24, 2023 05:52
@marcalexiei
Copy link
Contributor Author

marcalexiei commented Jul 24, 2023 •
edited

Requested changes applied. Let me know if anything else is needed.

@kyletsang kyletsang merged commit 57b4e29 into react-bootstrap:master Jul 25, 2023
12 of 13 checks passed
@kyletsang
Copy link
Member

Thanks

@marcalexiei marcalexiei deleted the feature/plaintext-size branch July 25, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcalexiei @kyletsang