Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug broken responsive navbar in docs #6671

Closed
3 tasks done
PatrikTrefil opened this issue Jul 28, 2023 · 5 comments · Fixed by #6673
Closed
3 tasks done

Bug broken responsive navbar in docs #6671

PatrikTrefil opened this issue Jul 28, 2023 · 5 comments · Fixed by #6673
Labels

Comments

@PatrikTrefil
Copy link

Prerequisites

Describe the bug

The documentation examples in the Navbar section are broken. When a user triggers a collapse into a hamburger menu and then tries to expand the menu by clicking the hamburger icon, the UI breaks.

Expected behavior

There should not be multiple layers of text.

To Reproduce

  1. Go to this link
  2. Go to the first example
  3. Make the navbar collapse by zooming in or making the browser behave like a phone/tablet.
  4. Click on the hamburger menu

Reproducible Example

https://react-bootstrap.github.io/docs/components/navbar/#overview

Screenshots

Screenshot 2023-07-28 145408

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome, Firefox

What version of React-Bootstrap are you using?

What version of Bootstrap are you using?

Additional context

No response

@asamad35
Copy link
Contributor

asamad35 commented Aug 1, 2023

Hey @PatrikTrefil, fixed the issue, have a look at PR.

@PatrikTrefil
Copy link
Author

Good work @asamad35!

@CodeMode365
Copy link

If this is fixed why the issue is still open?

@PatrikTrefil
Copy link
Author

If this is fixed why the issue is still open?

PR is not merged yet.

@asamad35
Copy link
Contributor

Good work @asamad35!

Thank you.
I have updated the code to maintain consistency. What can I do to make this PR get merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants