Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a Modal is open keep focus on the Modal #723

Closed
mtscout6 opened this issue May 23, 2015 · 2 comments
Closed

When a Modal is open keep focus on the Modal #723

mtscout6 opened this issue May 23, 2015 · 2 comments

Comments

@mtscout6
Copy link
Member

You can currently "tab" off the Modal into elements under the Modal. This is both bad practice and required for Accessibility.

/cc @jportela

@citelao
Copy link

citelao commented May 26, 2015

The code here is fairly robust, aside from relying on a constant selector string of tabbable elements (a[href], area[href], input:not([disabled]), ...).

Note, the selector string should be *[tabindex]:not([tabindex=-1]) at the end, instead of *[tabindex].

See here for an implementation in React (/shameless plug)

@jquense
Copy link
Member

jquense commented Jun 17, 2015

fixed in #810

@jquense jquense closed this as completed Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants