Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

justified button groups render incorrectly #83

Closed
kastork opened this issue May 27, 2014 · 3 comments
Closed

justified button groups render incorrectly #83

kastork opened this issue May 27, 2014 · 3 comments

Comments

@kastork
Copy link

kastork commented May 27, 2014

<ButtonGroup justified>

renders

class="btn-group btn-group-justified"

The bootstrap docs suggest it should be

class="btn-group.btn-group-justified"
@kastork
Copy link
Author

kastork commented May 27, 2014

Arg, never mind.

Proper use involves nested ButtonGroup components.

@kastork kastork closed this as completed May 27, 2014
@MPieter
Copy link

MPieter commented Aug 28, 2015

Just looking for some clarification on this topic.

The proper way of rendering a justified ButtonGroup is thus:

            <ButtonGroup justified>
                <ButtonGroup>
                        <Button>Button 1</Button>
                </ButtonGroup>
                <ButtonGroup>
                        <Button>Button 2</Button>
                </ButtonGroup>
                <ButtonGroup>
                        <Button>Button 3</Button>
                </ButtonGroup>
                <ButtonGroup>
                        <Button>Button 4</Button>
                </ButtonGroup>
            </ButtonGroup>

Isn't this really verbose ? Isn't this something that could be taken care of by the react-bootstrap library?

And maybe we should update the docs on this topic ?The current version could use some clarification: http://react-bootstrap.github.io/components.html#btn-groups-justified

@taion
Copy link
Member

taion commented Aug 28, 2015

No, that's not right. Follow the example on the components page. It looks like the OP doesn't understand .btn-group.btn-group-justified means - the markup we render follows what's in upstream Bootstrap.

aryad14 pushed a commit to aryad14/react-bootstrap that referenced this issue Oct 11, 2023
Using fromCharCode instead of HTML entity for representing close
aryad14 pushed a commit to aryad14/react-bootstrap that referenced this issue Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants