Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 tests failing with React master #98

Closed
stevoland opened this issue Jun 10, 2014 · 0 comments · Fixed by #151
Closed

2 tests failing with React master #98

stevoland opened this issue Jun 10, 2014 · 0 comments · Fixed by #151

Comments

@stevoland
Copy link
Contributor 

Chrome 35.0.1916 (Mac OS X 10.9.2) DropdownButton when open should close on click FAILED
    Error: timeout of 2000ms exceeded
        at /Users/stephencollings/ukc/react-bootstrap/node_modules/mocha/mocha.js:4241:14
Chrome 35.0.1916 (Mac OS X 10.9.2) SplitButton when open should close when button is clicked FAILED
    Error: timeout of 2000ms exceeded
        at /Users/stephencollings/ukc/react-bootstrap/node_modules/mocha/mocha.js:4241:14
Chrome 35.0.1916 (Mac OS X 10.9.2): Executed 162 of 162 (2 FAILED) (5.016 secs / 4.24 secs)
pieterv added a commit to pieterv/react-bootstrap that referenced this issue Jul 12, 2014
@pieterv
Remove instance.componentDidUpdate overriding since this is no longer
e763d14 
possible on React 0.11.

Fixes react-bootstrap#98
@pieterv pieterv mentioned this issue Jul 12, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

React master compatibility pieterv/react-bootstrap
1 participant
@stevoland