Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavItemLink not closing after click #60

Closed
andrerpena opened this issue May 27, 2015 · 5 comments
Closed

NavItemLink not closing after click #60

andrerpena opened this issue May 27, 2015 · 5 comments

Comments

@andrerpena
Copy link

Hi.
Thanks for the awesome work.
I'm trying react-router-bootstrap with react-starter right now and I noticed that NavItemLink it's not closing after I click it. I mean, it's actually working, but it's not closing.
Is it something obvious? Or do you need implementation details?
I really appreciate the help.

@andrerpena
Copy link
Author

My guess is that the click is not changing the menu state.. so react-router re-renders but the "open" state persists.

@mtscout6
Copy link
Member

I'm presuming that you mean it does not work when the Navbar is rendered in a mobile view? Because otherwise NavItems in general are not in a dropdown unless that is the case.

@mtscout6
Copy link
Member

We'd take a PR to fix this. Though it may be related to react-bootstrap/react-bootstrap#419 and require a fix in react-bootstrap first.

@andrerpena
Copy link
Author

Thanks for the response.

I'm not on Mobile, I'm just using the default NavBar from React-Bootstrap, the one with a dropdown menu: http://react-bootstrap.github.io/components.html#navbars

Screenshot:
image

If, instead of using NavItem, if I use NavItemLink, it will not close the dropdown on click.

Could you suggest a workaround while you don't have that fixed?

@mtscout6
Copy link
Member

If it's with the dropdown than it's a duplicate of #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants