Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eslint linting #69

Closed
AlexKVal opened this issue Jun 9, 2015 · 4 comments
Closed

Implement eslint linting #69

AlexKVal opened this issue Jun 9, 2015 · 4 comments

Comments

@AlexKVal
Copy link
Member

AlexKVal commented Jun 9, 2015

As a start point these are the lines from the old (long unused) code:

jshint: {
  enforceall: true,
  // jsx splat will make this fail
  eqnull: true,
  camelcase: false,
  nocomma: false,
  browser: true,
  singleGroups: false,
  emitErrors: true,
  failOnHint: true
}
@mtscout6
Copy link
Member

mtscout6 commented Jun 9, 2015

I assume this is only for codeclimate or bithound?

@mtscout6
Copy link
Member

mtscout6 commented Jun 9, 2015

Nevermind I just realized that you took this out of the old webpack.config file. I'd rather use eslint, with a similar configuration to react-bootstrap.

@AlexKVal AlexKVal changed the title Add linting Implement eslint linting Jun 9, 2015
@AlexKVal
Copy link
Member Author

AlexKVal commented Jun 9, 2015

Yeah. I thought about eslint too. Just forgot to mention it here.

@taion
Copy link
Member

taion commented Jun 10, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants