Fixed re-render not updating MapView.Circle component in UI when radius or center coordinates change. #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rostislav-simonik
pushed a commit
to technology-studio-forks/react-native-maps
that referenced
this pull request
Jul 4, 2018
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
Not currently.
What issue is this PR fixing?
The circle will not re-render when radius or center changes. This is due to a simple mistake in AIRMap.m
#187 (comment)
How did you test this PR?
Tested by creating a project in which the radius and lat/lng values can be changed dynamically. When these values change, the corresponding re-render updates the view to match the new values.