Fix Xcode warnings for format, pointer type, unused var #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed these warnings when using this library inside Expo. Changed NULL to 0 for the NSStringCompareOptions flag; cast the NSIntegers to long when using as a string format argument; removed unused variable zoomLevel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed these warnings when using this library inside Expo. Changed NULL to 0 for the NSStringCompareOptions flag; cast the NSIntegers to long when using as a string format argument; removed unused variable zoomLevel.
Does any other open PR do the same thing?
Not as far as I can tell.
What issue is this PR fixing?
There are some annoying compiler warnings in Xcode and this makes them go away.
How did you test this PR?
I compiled the lib.