Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with css-modules #14

Closed
alexbardas opened this issue Jul 30, 2016 · 1 comment · Fixed by #15
Closed

Incompatibility with css-modules #14

alexbardas opened this issue Jul 30, 2016 · 1 comment · Fixed by #15

Comments

@alexbardas
Copy link
Contributor

Hi,

rc-animate seems to be incompatible with css-modules right now. More context about this issue can be found here. If transitionName is an object, appearActive, enterActive and leaveActive properties are not used.

There's also an issue in css-animate because '-active' is hardcoded for any animation.

Css modules seems to have quite a big adoption right now, so a backwards compatible change would make sense in my opinion.

@yiminghe
Copy link
Member

yiminghe commented Aug 1, 2016

transitionName={{
    enter: style.enter,
    enterActive: style.enterActive,
    leave: style.leave,
    leaveActive: style.leaveActive,
  }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants