Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusable typescript typing #108

Closed
ilnicki opened this issue Jun 6, 2019 · 0 comments
Closed

Unusable typescript typing #108

ilnicki opened this issue Jun 6, 2019 · 0 comments

Comments

@ilnicki
Copy link
Contributor

ilnicki commented Jun 6, 2019

Current index.d.ts declares every prop as required. This is not actually true and completely breaks ability of the component being used with ts. I propose to make everything optional. It should not break any compatibility while make the component easier to use. Also it needs some improvements with type clarification but it can break some things.

@ilnicki ilnicki mentioned this issue Jun 6, 2019
@ilnicki ilnicki closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant