Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to close notification using the Enter key #299

Closed
MehmetYararVX opened this issue Feb 28, 2023 · 0 comments · Fixed by #302
Closed

Unable to close notification using the Enter key #299

MehmetYararVX opened this issue Feb 28, 2023 · 0 comments · Fixed by #302

Comments

@MehmetYararVX
Copy link
Contributor

MehmetYararVX commented Feb 28, 2023 •
edited
Loading

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Load the sandbox
  2. Click Show notification
  3. See that the close icon gets focus and turns red
  4. See that the notification is not closed after 1s (simulated keyboard event via timeout)
  5. (Optional) Simulate the click event and see that the notification gets closed after 1s

What is expected?

When close button has keyboard focus, pressing Enter on the keyboard should close the notification.

What is actually happening?

When close button has keyboard focus, pressing Enter on the keyboard does not close the notification.

Environment Info
rc-notification 4.6.0
React 18
System ALL
Browser ALL

Ref: UIEN-1752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: close notification with Enter key MehmetYararVX/notification
1 participant
@MehmetYararVX