feat: add keepAlign props #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 90.90% 81.25% -9.66%
==========================================
Files 3 3
Lines 33 48 +15
Branches 12 14 +2
==========================================
+ Hits 30 39 +9
- Misses 3 9 +6
Continue to review full report at Codecov.
|
|
|
|
我之前试过把 getPopupContainer 设置为当前元素，这样会一直跟着移动。 但是会有样式问题，因为 handle 的宽度非常小，里面的 tooltip 内容如果多一点，就会换行。 |
|
能搞个 branch 我看看不？ |
|
react-component/slider#696 看这个 PR 的预览链接。 |
shc023
pushed a commit
to shc023/tooltip
that referenced
this pull request
Jul 31, 2021
…nt#227) * show popup at the same document as the trigger element * use current document in all use cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改动点
添加
keepAlign属性，当子元素移动时，是否始终保持与子元素对齐，默认为false。解决的问题
发现在 在
rc-tooltip@3.7.3版本及其之前版本是有这个特性的，之后版本就没有了，应该是rc-trigger升级导致。这样以来，rc-slider拖拽时，tooltip 就不会随着 handle 位置改变而改变(https://github.com/react-component/slider/issues/693)。在
antd中也为 Slider 开发了这个功能，因此这次把这个功能移植到rc-tooltip中来，顺便解决rc-slider的问题。@afc163 @zombieJ 觉得没问题的话，我再加上测试用例。