Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip crashes #35

Closed
benjycui opened this issue Nov 25, 2015 · 4 comments
Closed

Tooltip crashes #35

benjycui opened this issue Nov 25, 2015 · 4 comments
Assignees
@benjycui

Comments

@benjycui
Copy link
Member

See: react-component/slider#52
@benjycui benjycui self-assigned this Nov 25, 2015
@benjycui benjycui mentioned this issue Nov 25, 2015
Closed
@benjycui
Copy link
Member Author

isMounted is going to be deprecated, see: facebook/react#5465

Here is a hack.

I am going to use this hack as a patch. And then, I will try to find a better solution, but need more time. @yiminghe

@yiminghe
Copy link
Member

和这个没关系，react 0.14.1 修复的

facebook/react#5125

@benjycui
Copy link
Member Author

嗯，不过 isMounted 还是要去掉吧？已经计划 deprecated 了。

@yiminghe
Copy link
Member

还没有结论，去掉后反而自己要做很多事情，不合理

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjycui benjycui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yiminghe @benjycui