Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure port and host of the server #139

Closed
w0rm opened this issue Jun 10, 2015 · 1 comment
Closed

Configure port and host of the server #139

w0rm opened this issue Jun 10, 2015 · 1 comment

Comments

@w0rm
Copy link
Contributor

w0rm commented Jun 10, 2015

I need to dockerize cosmos, but I can't, because it only listens on localhost, not '0.0.0.0'.
What would be a preferred way to set port and host of the server? I am willing to work on this feature.

@ovidiuch
Copy link
Member

I prefer the config more than the cli args. Out the back of my head, I'm thinking:

  1. Abstract the getUserConfig part into a lib so that it can be reused
  2. Use it in the bin file to override the localhost:8989 settings
  3. These settings could be set under userConfig.server.[hostname|port], except they would be just properties and not a method like the webpack config (hopefully it's not too confusing to be different)

What do you think? I'm open to other suggestions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants