Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MouseUp manual blur()s close day picker in IE #1606

Open
bdrazen opened this issue Apr 2, 2019 · 0 comments · May be fixed by #1607
Open

MouseUp manual blur()s close day picker in IE #1606

bdrazen opened this issue Apr 2, 2019 · 0 comments · May be fixed by #1607

Comments

@bdrazen
Copy link

bdrazen commented Apr 2, 2019 •
edited
Loading

react-dates version
e.g. react-dates@18.3.1

Describe the bug
Manual blur triggers on MouseUp cause the day picker to close in IE. Can be reproduced by changing the month or clicking the keyboard shortcuts icon.

Is the issue reproducible in Storybook?
http://airbnb.io/react-dates/?selectedKind=SingleDatePicker%20%28SDP%29&selectedStory=default&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

Additional context
Commenting out the .blur() lines in the following files prevents the behaviour:

src/components/DayPicker.jsx
src/components/DayPickerKeyboardShortcuts.jsx
src/components/DayPickerNavigation.jsx
@bdrazen bdrazen changed the title MouseUp manual blur triggers close day picker in IE MouseUp manual blur()s close day picker in IE Apr 2, 2019
This was referenced Apr 3, 2019
Open
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace programmatic blurs with mousedown preventDefault bdrazen/react-dates
1 participant
@bdrazen