Why does isOutsideRange get called multiple times for each date, and at different times (midnight vs noon)?

[opqpop]

react-dates version
react-dates@21.8.0

Describe the bug
isOutsideRange prop callback is passing each calendar day multiple times for some reason

specifically, each date can be called at local time midnight or local time noon, which makes it hard for me to know which one I'm supposed to compare for to return a correct value to isOutSideRange

expected behavior: returns consistent time, either always midnight local time or always noon local time

Source code (including props configuration)
Load and see strange output

<DayPickerRangeController
  isOutsideRange={(date) => console.log('huh', date.format())}
/>

zoom_0.mp4

Desktop (please complete the following information):

• OS: mac
• Browser chrome
• Version 92.0.4515.107 (Official Build) (x86_64)

[ljharb]

I'd expect always noon, since midnight doesn't always exist. This seems like a bug.

[glintik]

Hi @ljharb,

Proposed a fix for this issue, please take a look.
I introduced simple cache to mitigate multiple isOutsideRange and isDayBlocked, it works as expected and tests passed, but would like to see your thoughts about this implementation.

[ljharb]

A cache isn’t a good idea, because the callback may need to be called multiple times.

the fix is to not use midnight.

[opqpop]

Wow, thanks for both of your help! Exciting to see the potential fix!

[opqpop]

Hi, wanted to ask if this ever got fixed? I'm still struggling to figure out how to deal with this, as I'm currently assuming noon time, but it'll still give me midnight time sometimes causing my users to see strange bugs

[opqpop]

Ah nvm, sorry for the thrash, I see that #2146 was merged in! Thank you so much for the fix! Will test this out more and see what might be going on

[ljharb]

@opqpop it's been merged, but not yet released.

[opqpop]

Ah okay thanks, any ETA on when that might be?

Meanwhile, I dug into it and threw in something like this in my callsite, which seems to have helped with some of the bugs

const hoursToAdd = reactDateDay.format('H') == '0' ? 12 : 0
const standardizedDay = reactDateDay.clone().add(hoursToAdd, 'hours')

[nathanredblur]

I have similar issue, but with timezones
I notice the same date is called multiple times using different timezones.
any idea what could it be?