Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Use verticalScrollable DayPickerRangeControllerWrapper renders Empty #2226

Closed
pedromoter opened this issue Feb 10, 2023 · 1 comment
Closed

Comments

@pedromoter
Copy link

pedromoter commented Feb 10, 2023

react-dates version
e.g. react-dates@18.3.1
21.8.3

Describe the bug
I am using the wrapped implementation of DayPickerRangeControllerWrapper given in the examples but I cannot use the orientation verticalScrollable t

Source code (including props configuration)
Steps to reproduce the behavior:

  <DayPickerRangeControllerWrapper 
          autoFocusEndDate={false}     
          minimumNights={3}
          hideKeyboardShortcutsPanel
          numberOfMonths={12}
          orientation="verticalScrollable"
          initialStartDate={moment()}
          initialVisibleMonth={() => moment().add(2, "M")} // PropTypes.func or null,
          verticalHeight={800} />

If you have custom methods that you are passing into a react-dates component, e.g. onDatesChange, onFocusChange, renderMonth, isDayBlocked, etc., please include the source for those as well.
Nope

Screenshots/Gifs
If applicable, add screenshots or gifs to help explain your problem.
Screenshot 2023-02-09 at 10 03 56 PM

Just renders empty like this.
Read the docs multiple times orientation allows for VerticalScrollable in the DatePickerRangeController.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
    MAC OS Chrome latest

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Is the issue reproducible in Storybook?
Please link to the relevant storybook example
Nope

Additional context
Add any other context about the problem here.

Works fine with orientation scrollable and vertical. same code just changing the prop value

@pedromoter
Copy link
Author

My bad, just realized that i had to set a parent compoennt height

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant