Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dragging multiple files when multiple false doesn't apply rejectStyle #489

Merged
merged 9 commits into from Sep 4, 2017
Merged

Conversation

ianhowe76
Copy link
Contributor

@ianhowe76 ianhowe76 commented Sep 1, 2017

What kind of change does this PR introduce?

  • bugfix
  • feature
  • refactoring / style
  • build / chore
  • documentation

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary

Does this PR introduce a breaking change?

Other information
closes #488

@codecov
Copy link

codecov bot commented Sep 1, 2017

Codecov Report

Merging #489 into master will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #489     +/-   ##
=========================================
+ Coverage   96.44%   96.95%   +0.5%     
=========================================
  Files           3        3             
  Lines         197      197             
  Branches       51       51             
=========================================
+ Hits          190      191      +1     
+ Misses          7        6      -1
Impacted Files Coverage Δ
src/index.js 97.07% <100%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c99df...7a180d9. Read the comment docs.

@okonet
Copy link
Collaborator

okonet commented Sep 1, 2017

Thanks for submitting it! Could you please add a relevant test for it?

@ianhowe76
Copy link
Contributor Author

Added tests

@okonet
Copy link
Collaborator

okonet commented Sep 1, 2017

@ianhowe76 CI build is failing. Can you please fix it?

@okonet okonet merged commit a5471a5 into react-dropzone:master Sep 4, 2017
@okonet
Copy link
Collaborator

okonet commented Sep 4, 2017

Thanks @ianhowe76 for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging multiple files when multiple false doesn't apply rejectStyle
3 participants