fix: call setState before callbacks #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 3 3
Lines 226 226
Branches 68 68
=======================================
Hits 224 224
Misses 2 2
Continue to review full report at Codecov.
|
rolandjitsu
requested changes
Oct 11, 2018
src/index.js
Outdated
| // Update `acceptedFiles` and `rejectedFiles` state | ||
| // This will make children render functions receive the appropriate | ||
| // values | ||
| this.setState({ acceptedFiles, rejectedFiles }) |
There was a problem hiding this comment.
Actually, this still does not have any guarantee that the cb fn will be called after the state is set (.setState() is async).
What you want is to have the onDrop* cb fns called in the .setState({...}, () => /* call the onDrop* fns here */) cb fn 😄
Also, add a test for this.
rolandjitsu
requested changes
Oct 12, 2018
rolandjitsu
requested changes
Oct 12, 2018
|
Ugh, wrong button. |
rolandjitsu
approved these changes
Oct 13, 2018
|
🎉 This PR is included in version 6.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
A potential fix for: #689
Does this PR introduce a breaking change?
Nope
Other information