fix: improve drag type detection and fix styling in Safari #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
- Coverage 99.11% 98.15% -0.96%
==========================================
Files 3 3
Lines 226 217 -9
Branches 68 63 -5
==========================================
- Hits 224 213 -11
- Misses 2 3 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
- cleanup some of the tests - apply different active styling when file type cannot be inferred and close react-dropzone#668 - use DataTransfer{types} for drag data type detection
rolandjitsu
force-pushed
the
fix/drag-active
branch
from
952dcc8
to
1dcd832
Compare
okonet
approved these changes
Oct 13, 2018
|
🎉 This PR is included in version 6.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rolandjitsu
added a commit
to rolandjitsu/react-dropzone
that referenced
this pull request
Oct 14, 2018
- do not use synthetic default imports in typings, close react-dropzone#696 - invoke onDrop when called from input change, close react-dropzone#698 - add more tests to increase coverage
rolandjitsu
added a commit
to rolandjitsu/react-dropzone
that referenced
this pull request
Oct 14, 2018
- do not use synthetic default imports in typings, close react-dropzone#696 - invoke onDrop when called from input change, close react-dropzone#698 - add more tests to increase coverage
rolandjitsu
added a commit
that referenced
this pull request
Oct 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
We currently rely on getting the data transfer data to detect what kind of data is being dragged. While that works in Chrome, Firefox and Edge, it does not work in Safari.
Hence this PR which uses {types} to do the data type detection.
And a few other things:
Does this PR introduce a breaking change?
No.
Other information