Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Auto resizing does not work in Learning Analytics apps #254

Open
sten opened this issue Jan 28, 2015 · 6 comments
Open

Auto resizing does not work in Learning Analytics apps #254

sten opened this issue Jan 28, 2015 · 6 comments
Assignees
Labels

Comments

@sten
Copy link
Member

sten commented Jan 28, 2015

The following learning analytics widgets do not properly resize to their requested height:

http://www.golabz.eu/apps/student-time-spent
http://www.golabz.eu/apps/online-users-visualisation

I have tried it on Safari, Chrome and Firefox (Mac). @davidsandoz can you fix this?

@davidsandoz
Copy link
Contributor

@sten The last version of the online users gadget (merged 2 days ago) seems to work better with resizing.
For the time spent gadget, I have the issue only with Firefox. I'll try to fix it with the enhancement I'm currently working on: #250

@davidsandoz
Copy link
Contributor

@sten After some more tests, it looks like the last version of the online users gadget doesn't always resize well. Although sometimes it does, which doesn't help much to determine if it is fixed or not. I'll have a look.

@sten
Copy link
Member Author

sten commented Jan 28, 2015

From my personal experience with the notorious adjustHeight function, it is important not too call it too early and often. It is an expensive operation that involves RPC. So try to call it once you are sure about the size of the gadget and do not connect in on load on any resize event. maybe this helps.

@davidsandoz
Copy link
Contributor

Thanks for the tips. A first solution that seems to work is simply wait for 5 seconds before calling adjustHeight. I suppose there can be a better solution. I'll try to find the best place to call it.

@voz
Copy link
Contributor

voz commented Feb 5, 2015

@davidsandoz could you submit a fix with the delay, maybe you should put it onload?

@voz
Copy link
Contributor

voz commented Feb 5, 2015

@davidsandoz We just have a session tomorrow, so if you have an opportunity to submit a quick fix, that would be great.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants