Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the methods in /lib/helper? #126

Closed
1 of 3 tasks
wlchn opened this issue Nov 8, 2019 · 3 comments
Closed
1 of 3 tasks

Where are the methods in /lib/helper? #126

wlchn opened this issue Nov 8, 2019 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@wlchn
Copy link
Contributor

wlchn commented Nov 8, 2019

I'm submitting a...

  • bug
  • feature
  • chore

I used react-stockcharts before, Are these methods in /lib/helper removed?

import { fitDimensions, fitWidth } from 'react-stockcharts/lib/helper';
@markmcdowell
Copy link
Collaborator

markmcdowell commented Nov 8, 2019

Hi there! I’ve removed these so this library can focus on the charting.

In the stories examples I’ve added a HOC which does the same thing but will work for more use cases:

https://github.com/reactivemarkets/react-financial-charts/blob/master/packages/stories/src/data/withSize.tsx

GitHub
Charts dedicated to finance. Contribute to reactivemarkets/react-financial-charts development by creating an account on GitHub.

@markmcdowell markmcdowell self-assigned this Nov 8, 2019
@markmcdowell markmcdowell added the question Further information is requested label Nov 8, 2019
@wlchn
Copy link
Contributor Author

wlchn commented Nov 8, 2019

Awesome! thx

@wlchn wlchn closed this as completed Nov 8, 2019
@lock
Copy link

lock bot commented Nov 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Development

No branches or pull requests

2 participants