Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with @types/react v18.x due to removal of children from FC and Component types #647

Closed
ashmortar opened this issue Apr 12, 2022 · 4 comments · Fixed by #648
Closed

Incompatible with @types/react v18.x due to removal of children from FC and Component types #647

ashmortar opened this issue Apr 12, 2022 · 4 comments · Fixed by #648

Comments

@ashmortar
Copy link

If you update @types/react to version 18 it introduces a breaking change that makes <DraggableCore/> fail typescript compilation. This is due to the removal of implicit children from FC and Component.

Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly<Partial>, never> & Partial<...> & Partial<...>'.ts(2769)
@sseemmiin
Copy link

same as me

@SebastiaanNijland SebastiaanNijland mentioned this issue Apr 13, 2022
Merged
@samyan
Copy link

samyan commented Apr 19, 2022

same here

@mahdi-farnia
Copy link

same

@STRML
Copy link
Collaborator

STRML commented Apr 26, 2022

Fixed in 4.4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add children to the DraggableCoreProps SebastiaanNijland/react-draggable
5 participants
@STRML @samyan @ashmortar @sseemmiin @mahdi-farnia