Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prop-types): make width and height prop conditionally required #196

Merged
merged 2 commits into from
Apr 21, 2022
Merged

fix(prop-types): make width and height prop conditionally required #196

merged 2 commits into from
Apr 21, 2022

Conversation

armedi
Copy link
Contributor

@armedi armedi commented Apr 21, 2022

Fixes #6

The issue was closed, but actually it's not fully fixed yet. My comment on the issue: #6 (comment)

@STRML STRML merged commit eb78651 into react-grid-layout:master Apr 21, 2022
@STRML
Copy link
Collaborator

STRML commented Apr 21, 2022

Thanks!

@ruddenchaux ruddenchaux mentioned this pull request Jul 12, 2022
Merged
@vitaliydolbilov vitaliydolbilov mentioned this pull request Oct 14, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove required "width" prop
2 participants
@armedi @STRML