-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State that isValid
only works with modes: onChange and onBlur
#151
Comments
hey @iamdevlinph what's the usage of isValid for onSubmit mode? |
I was expecting it to work this way. When user triggers a submit then the whole form validation is triggered. But if the user only updates a field then that should also update the |
Since in a sense, the state of the form has been updated because the user updated a field. |
then that's more of usage for |
happy to adjust for a good reason from UI perspective. |
or i can update the documentation to reflect this. |
Yes. Just an update to the documentation would be nice. Since it was not obvious to me that the No need to make changes to the functionality. |
you want to submit a PR @iamdevlinph ? would love to see your name at contribution list. |
Sure. I'll open one later. Though it's just a minor change lol |
it's good to have your name on the list, you help quite bit on bug and answering questions at spectrum. thank you |
No worries. This package also helped me a lot 👍 |
I'm not sure if this is stated but it would great to have this beside the
isValid
.I can open a PR later for this minor thing if needed.
The text was updated successfully, but these errors were encountered: