Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue: setValue with shouldDirty and shouldTouch combine not update state correctly #7506

Closed
1 task done
Moshyfawn opened this issue Jan 12, 2022 · 5 comments · Fixed by #7508
Closed
1 task done

issue: setValue with shouldDirty and shouldTouch combine not update state correctly #7506

Moshyfawn opened this issue Jan 12, 2022 · 5 comments · Fixed by #7508
Labels
bug Something isn't working

Comments

@Moshyfawn
Copy link
Member

Moshyfawn commented Jan 12, 2022 •
edited
Loading

Version Number

7.22.5

Codesandbox/Expo snack

https://codesandbox.io/s/should-dirty-fail-qnsfm

Steps to reproduce

  1. Go to codesandbox
  2. Click on "John" button
  3. See firstName input Dirty field in devtools not set to true

Expected behaviour

The firstName field is set as dirty

What browsers are you seeing the problem on?

Firefox, Chrome, Safari

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Moshyfawn Moshyfawn added the status: under investigation aware of this issue and pending for investigation label Jan 12, 2022
@bluebill1049 bluebill1049 added bug Something isn't working and removed status: under investigation aware of this issue and pending for investigation labels Jan 12, 2022
@bluebill1049 bluebill1049 changed the title issue: issue: setValue with shouldDirty and shouldTouch combine not update state correctly Jan 12, 2022
@Moshyfawn Moshyfawn changed the title issue: setValue with shouldDirty and shouldTouch combine not update state correctly issue: setValue doesn't set input field as dirty with shouldDirty Jan 12, 2022
@Moshyfawn Moshyfawn changed the title issue: setValue doesn't set input field as dirty with shouldDirty issue: setValue with shouldDirty and shouldTouch combine not update state correctly Jan 12, 2022
@bluebill1049
Copy link
Member

thank you @Moshyfawn.

@bluebill1049 bluebill1049 mentioned this issue Jan 12, 2022
Merged
@bluebill1049
Copy link
Member

fixed: #7508

@bayou-brogrammer
Copy link

bayou-brogrammer commented Jan 12, 2022 •
edited
Loading

@bluebill1049 I believe the issue is still occuring. Using the sandbox from above and changing the react-hook-version to v7.230 it still doesnt set both

@Moshyfawn
Copy link
Member Author

@bluebill1049 I believe the issue is still occuring. Using the sandbox from above and changing the react-hook-version to v7.230 it still doesnt set both

Yep, I thought it's the Codesandbox package versions cache issue, but can reproduce in a local environment

@bayou-brogrammer bayou-brogrammer mentioned this issue Jan 12, 2022
Closed
1 task
@bluebill1049
Copy link
Member

not released yet.

@Moshyfawn Moshyfawn mentioned this issue Jan 13, 2022
Closed
1 task
@bluebill1049 bluebill1049 removed their assignment Jan 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@bayou-brogrammer @bluebill1049 @Moshyfawn