feat: rename all hook implementation files to index.ts
#1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1065 +/- ##
==========================================
+ Coverage 96.66% 98.52% +1.85%
==========================================
Files 63 63
Lines 1111 1082 -29
Branches 180 180
==========================================
- Hits 1074 1066 -8
+ Misses 23 2 -21
Partials 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Jan 4, 2023
BREAKING CHANGE: all current hook implementation fies renamed to index
to allow usage of directory imports and avoid redundant reexporting.
Such change breaks previous direct imports, but simplifies import string
and solves redundant hook name duplication.
4ex:
```
// previously
import { useUpdate } from "@react-hookz/web/useUpdate/useUpdate"
// now
import { useUpdate } from "@react-hookz/web/useUpdate"
```
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
# [22.0.0](v21.0.0...v22.0.0) (2023-01-05) ### Features * rename all hook implementation files to `index.ts` ([#1065](#1065)) ([34c36f2](34c36f2)) ### BREAKING CHANGES * all current hook implementation fies renamed to index to allow usage of directory imports and avoid redundant reexporting. Such change breaks previous direct imports, but simplifies import string and solves redundant hook name duplication. 4ex: ``` // previously import { useUpdate } from "@react-hookz/web/useUpdate/useUpdate" // now import { useUpdate } from "@react-hookz/web/useUpdate" ```
|
🎉 This PR is included in version 22.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current scheme of files naming implied redundant duplication of hook name in case of direct imports, leading to more verbose and kind of littered imports block.
New scheme assumes that hook implementation should be within
index.tsfile, allowing directory imports and more granular control over hook exports overall.