Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply correct order of operations in useRerender #850

Merged
merged 1 commit into from
Jun 22, 2022
Merged

fix: Apply correct order of operations in useRerender #850

merged 1 commit into from
Jun 22, 2022

Conversation

KonradLinkowski
Copy link
Contributor

@KonradLinkowski KonradLinkowski commented Jun 21, 2022 •
edited

First add one to state and then get reminder of max safe integer

What is the current behavior, and the steps to reproduce the issue?

Modulo is never applied

What is the expected behavior?

Number is always smaller than MAX_SAFE_INTEGER

How does this PR fix the problem?

It applies correct order of operations

Checklist

  • Have you read contribution guideline?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Is there an existing issue for this PR?
    • link issue here
  • Have the files been linted and formatted?
  • Have the docs been updated to match the changes in the PR?
  • Have the tests been updated to match the changes in the PR?
  • Have you run the tests locally to confirm they pass?

@KonradLinkowski
Apply correct operations order
6155dee 
First add one to state and then get reminder of max safe integer
@KonradLinkowski KonradLinkowski changed the title Apply correct order of operations in useRerender fix: Apply correct order of operations in useRerender Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #850 (6155dee) into master (2df44c1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #850   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines          916       916           
  Branches       170       170           
=========================================
  Hits           916       916
Impacted Files Coverage Δ
src/useRerender/useRerender.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1941f3...6155dee. Read the comment docs.

@xobotyi xobotyi merged commit 5fc735a into react-hookz:master Jun 22, 2022
@xobotyi
Copy link
Contributor

xobotyi commented Jun 22, 2022

Thanks!

github-actions bot pushed a commit that referenced this pull request Jun 22, 2022
@semantic-release-bot
chore(release): 14.2.3 [skip ci]
6386122 
## [14.2.3](v14.2.2...v14.2.3) (2022-06-22)

### Bug Fixes

* apply correct order of operations in `useRerender` ([#850](#850)) ([5fc735a](5fc735a))
* change storybook builder to webpack5 ([#830](#830)) ([2df44c1](2df44c1))
@xobotyi
Copy link
Contributor

xobotyi commented Jun 22, 2022

🎉 This PR is included in version 14.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KonradLinkowski KonradLinkowski deleted the patch-1 branch June 23, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KonradLinkowski @xobotyi