Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fontawesome icons are broken / don't fit their viewport #10

Closed
Prinzhorn opened this issue Dec 4, 2015 · 5 comments
Closed

Some fontawesome icons are broken / don't fit their viewport #10

Prinzhorn opened this issue Dec 4, 2015 · 5 comments

Comments

@Prinzhorn
Copy link
Collaborator

Correct: https://github.com/gorangajic/react-icons/blob/323e5568347abb61323f75f70e63c346603a263e/icons/fa/repeat.svg

Incorrect: https://github.com/gorangajic/react-icons/blob/323e5568347abb61323f75f70e63c346603a263e/icons/fa/undo.svg
Also incorrect: https://github.com/gorangajic/react-icons/blob/323e5568347abb61323f75f70e63c346603a263e/icons/fa/gear.svg

I don't know how you pull these SVGs in and process them, but something went wrong for some of them.

@gorangajic
Copy link
Member

some icons in font awesome have more than one, thats why we had broken old icons that were duplicated.

for example
repeat => rotate-right
undo => rotate-left
gear => cog

Now they are removed 2a3f1bf

@Prinzhorn
Copy link
Collaborator Author

I see. How did you decide which ones to keep? E.g. undo is the official name and rotate-left the alias, but you kept rotate-left. http://fontawesome.io/icon/undo/

Is your whole process automated? If so, can't we support aliases? Like module.exports = require('./undo.js'); inside the rotate-left.js (or whatever the equivalent es6 is)?

@gorangajic
Copy link
Member

it's not all automated, it's look like it took first icon that come in alphabetical order.

At first I was using svg-caster to get svg icons from the font file, now I use https://icomoon.io/ because I thought that svg-caster was broken #6

@Prinzhorn
Copy link
Collaborator Author

But now 1.0.3 is a breaking change, because some people (including me) already use fa icons which are now removed. We should keep them and automate everything. Discussion here: #11

@gorangajic
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants