New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fontawesome icons are broken / don't fit their viewport #10
Comments
some icons in font awesome have more than one, thats why we had broken old icons that were duplicated. for example Now they are removed 2a3f1bf |
I see. How did you decide which ones to keep? E.g. Is your whole process automated? If so, can't we support aliases? Like |
it's not all automated, it's look like it took first icon that come in alphabetical order. At first I was using svg-caster to get svg icons from the font file, now I use https://icomoon.io/ because I thought that svg-caster was broken #6 |
But now 1.0.3 is a breaking change, because some people (including me) already use fa icons which are now removed. We should keep them and automate everything. Discussion here: #11 |
👍 |
Correct: https://github.com/gorangajic/react-icons/blob/323e5568347abb61323f75f70e63c346603a263e/icons/fa/repeat.svg
Incorrect: https://github.com/gorangajic/react-icons/blob/323e5568347abb61323f75f70e63c346603a263e/icons/fa/undo.svg
Also incorrect: https://github.com/gorangajic/react-icons/blob/323e5568347abb61323f75f70e63c346603a263e/icons/fa/gear.svg
I don't know how you pull these SVGs in and process them, but something went wrong for some of them.
The text was updated successfully, but these errors were encountered: