Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility support #110

Closed
iDVB opened this issue Aug 21, 2017 · 8 comments
Closed

Accessibility support #110

iDVB opened this issue Aug 21, 2017 · 8 comments

Comments

@iDVB
Copy link

iDVB commented Aug 21, 2017

Just noticing that currently react-icons does not support passing down the title and description for the icons. Any chance this can be added? Would you accept a PR?
https://css-tricks.com/accessible-svgs/#article-header-id-6

Maybe the best place to include this is to have react-icon-base optionally include this at the top of the SVGs IF a title or description is provided?

@silvenon
Copy link

Yeah, this would be awesome.

@mryechkin
Copy link

Agreed, it would be great to see this added.

The project I'm working on now requires AODA compliance, and this feature is one thing we're having some trouble with for actionable icons. Using a separate label with aria-hidden="true" doesn't work as nicely with iOS voice assistance

@iDVB
Copy link
Author

iDVB commented Nov 28, 2017

I've got this ready to PR, other then I'm trying to figure out the proper unit tests to write for it.
@gorangajic any suggestions on this PR? gorangajic/react-icon-base#25

@nscarcella
Copy link

Any chance this will get implemented in the near future?

@kamijin-fanta
Copy link
Member

kamijin-fanta commented Aug 6, 2018

@silvenon @nscarcella @iDVB @mryechkin It may be resolved by using react-icons@3.0.0 or higher.

<FaFolder aria-labelledby="discribe" />

@Nantris
Copy link

Nantris commented Mar 24, 2019

Should we assume this isn't a planned feature?

@paustria
Copy link
Contributor

Please support this feature. I have to move away from react-icons because title doesn't support and the browser does not read icon.

@silvenon
Copy link

For those looking to migrate away, you can fairly easily roll your own icon system with <symbol>, copying code from IcoMoon: https://gist.github.com/silvenon/47857d019ed1fd0c032471604d0c0f53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants