-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility support #110
Comments
Yeah, this would be awesome. |
Agreed, it would be great to see this added. The project I'm working on now requires AODA compliance, and this feature is one thing we're having some trouble with for actionable icons. Using a separate label with aria-hidden="true" doesn't work as nicely with iOS voice assistance |
I've got this ready to PR, other then I'm trying to figure out the proper unit tests to write for it. |
Any chance this will get implemented in the near future? |
@silvenon @nscarcella @iDVB @mryechkin It may be resolved by using react-icons@3.0.0 or higher.
|
Should we assume this isn't a planned feature? |
Please support this feature. I have to move away from |
For those looking to migrate away, you can fairly easily roll your own icon system with |
Just noticing that currently react-icons does not support passing down the
title
anddescription
for the icons. Any chance this can be added? Would you accept a PR?https://css-tricks.com/accessible-svgs/#article-header-id-6
Maybe the best place to include this is to have
react-icon-base
optionally include this at the top of the SVGs IF atitle
ordescription
is provided?The text was updated successfully, but these errors were encountered: