Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All icons have a generic name of Component when snapshot #173

Closed
jktravis opened this issue Aug 8, 2018 · 3 comments · Fixed by #195
Closed

All icons have a generic name of Component when snapshot #173

jktravis opened this issue Aug 8, 2018 · 3 comments · Fixed by #195

Comments

@jktravis
Copy link

jktravis commented Aug 8, 2018

Is there something I'm doing wrong here, or do we lose the icon names when upgrading?

Before upgrading, if I add an icon of <FaBeer/> that name would show up in the snapshot. Now, regardless of the icon, I just get <Component/>.

@kamijin-fanta
Copy link
Member

are you using jest?
generation logic of the component was changed, so may have been changed.

@jktravis
Copy link
Author

jktravis commented Aug 9, 2018

Yes. v23.4.2

@SBoudrias
Copy link

Sounds like it's now missing a displayName static property on each icon components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants