Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model default scale #147

Closed
michbil opened this issue Feb 7, 2018 · 2 comments
Closed

Model default scale #147

michbil opened this issue Feb 7, 2018 · 2 comments

Comments

@michbil
Copy link

michbil commented Feb 7, 2018

I've tried to add model to my scene, and was struggling for some time, because model was invisible:

 <ARKit.Model
            position={{ x: -0.2, y: 0, z: 0, frame: 'local' }}
            scale={0.01}
            model={{
              file: 'art.scnassets/ship.scn', // make sure you have the model file in the ios project
            }}
          />

After some digging i've found if scale is not set this way, model is invisible:

 <ARKit.Model
            position={{ x: -0.2, y: 0, z: 0, frame: 'local' }}
            model={{
              file: 'art.scnassets/ship.scn', // make sure you have the model file in the ios project
              scale: 0.01,
            }}
          />

I think we need update project README.md, so it will be more clear how to use model component.

@macrozone
Copy link
Collaborator

hi @michbil thx for pointing this out!

actually the scale property on the model is deprecated, that's why i removed it from the README. Now every node (Box, Torus, Model, etc.) has a scale property.

The bug is actually that the scale on the model defaults incorrectly to 0 instead of 1. I try to fix that

@macrozone
Copy link
Collaborator

macrozone commented Feb 7, 2018

I released 0.8.0-beta.4 that no longer needs the scale property on model

edit: version 0.8.0 has been published as latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants