feat(example): Fix basic example bugs (#2751)

* feat(example): adding sound permissions to android example * feat(example): fix basic example runtime error
react-native-camera · Apr 5, 2020 · 9c18c25 · 9c18c25
1 parent 3ee43d4
commit 9c18c25
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 20 deletions.
diff --git a/examples/basic/App.js b/examples/basic/App.js
@@ -131,15 +131,15 @@ export default class CameraScreen extends React.Component {
     }
   };
 
-  takeVideo = async function() {
-    if (this.camera) {
+  takeVideo = async () => {
+    const { isRecording } = this.state;
+    if (this.camera && !isRecording) {
       try {
         const promise = this.camera.recordAsync(this.state.recordOptions);
 
         if (promise) {
           this.setState({ isRecording: true });
           const data = await promise;
-          this.setState({ isRecording: false });
           console.warn('takeVideo', data);
         }
       } catch (e) {
@@ -271,6 +271,41 @@ export default class CameraScreen extends React.Component {
     </React.Fragment>
   );
 
+  renderRecording = () => {
+    const { isRecording } = this.state;
+    const backgroundColor = isRecording ? 'white' : 'darkred';
+    const action = isRecording ? this.stopVideo : this.takeVideo;
+    const button = isRecording ? this.renderStopRecBtn() : this.renderRecBtn();
+    return (
+      <TouchableOpacity
+        style={[
+          styles.flipButton,
+          {
+            flex: 0.3,
+            alignSelf: 'flex-end',
+            backgroundColor,
+          },
+        ]}
+        onPress={() => action()}
+      >
+        {button}
+      </TouchableOpacity>
+    );
+  };
+
+  stopVideo = async () => {
+    await this.camera.stopRecording();
+    this.setState({ isRecording: false });
+  };
+
+  renderRecBtn() {
+    return <Text style={styles.flipText}> REC </Text>;
+  }
+
+  renderStopRecBtn() {
+    return <Text style={styles.flipText}> ☕ </Text>;
+  }
+
   renderCamera() {
     const { canDetectFaces, canDetectText, canDetectBarcode } = this.state;
 
@@ -390,23 +425,7 @@ export default class CameraScreen extends React.Component {
               alignSelf: 'flex-end',
             }}
           >
-            <TouchableOpacity
-              style={[
-                styles.flipButton,
-                {
-                  flex: 0.3,
-                  alignSelf: 'flex-end',
-                  backgroundColor: this.state.isRecording ? 'white' : 'darkred',
-                },
-              ]}
-              onPress={this.state.isRecording ? () => {} : this.takeVideo.bind(this)}
-            >
-              {this.state.isRecording ? (
-                <Text style={styles.flipText}> ☕ </Text>
-              ) : (
-                <Text style={styles.flipText}> REC </Text>
-              )}
-            </TouchableOpacity>
+            {this.renderRecording()}
           </View>
           {this.state.zoom !== 0 && (
             <Text style={[styles.flipText, styles.zoomText]}>Zoom: {this.state.zoom}</Text>

diff --git a/examples/basic/android/app/src/main/AndroidManifest.xml b/examples/basic/android/app/src/main/AndroidManifest.xml
@@ -8,6 +8,8 @@
     <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
     <uses-permission android:name="android.permission.VIBRATE"/>
     <uses-permission android:name="android.permission.CAMERA" />
+    <uses-permission android:name="android.permission.RECORD_AUDIO" />
+    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
 
     <application
       android:name=".MainApplication"