Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Typescript projects created with the CLI do not build/run correctly #65

Closed
bartolkaruza opened this issue Jan 9, 2019 · 2 comments

Comments

@bartolkaruza
Copy link

bartolkaruza commented Jan 9, 2019

Migrated from RN core: facebook/react-native#22914

This issue covers points 2 and 3 from the React Native issue posted above.

The project does not run. After building the project and attempting to run the project on a connected device and that fails because it's looking for the APK file in the wrong place, e.g. react-native run-android --deviceId results in the following:
adb: failed to stat app/build/outputs/apk/app-debug.apk: No such file or directory
Command failed: /usr/local/share/android-sdk/platform-tools/adb -s 99523a0828712a92 install app/build/outputs/apk/app-debug.apk
Could not install the app on the device, read the error above for details.

This is because the APK builds to apk/debug/app-debug.apk, not apk/app-debug.apk!!!

I even tried explicitly adding the --variant debug flag and it still insists on looking for the APK in the parent folder (instead of in the "debug" child folder where the APK was built to).

@grabbou
Copy link
Member

grabbou commented Jan 9, 2019

So this issue can be divided into two, separate parts: First, the OP has problems getting Typescript up & running (which is something to report to the maintainers of the Typescript template) and building the app on the simulator - which is something we should probably look at.

@grabbou
Copy link
Member

grabbou commented Jan 16, 2019

I wasn't able to reproduce this issue.

Closing as per this comment: facebook/react-native#22914 (comment)

@grabbou grabbou closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants