-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autolinking transitive native dependencies. (Component Library Monorepo) #923
Comments
We've hit this too - what we've been doing, for now, is adding the module as a peer and dev dependency in the component project and that at least then flags if it's not been added as a direct dependency in the top-level app. |
The same issue :( |
@liamjones Adding them as I have also tried manually linking these native modules, but it seems you are no longer able to link a package that is not directly defined in
@thymikee @grabbou @Esemesek Any insight on this? I don't think this is an obscure use-case. |
@cboar ah, you misunderstand. It doesn't fix the issue, no, but does result in yarn complaining about an unmet peer dependency which hopefully prompts the dev to add it as a direct dependency. :) |
Same problem as #870. Let's move the discussion there. |
We are running into issues with the autolinker not picking up on transitive dependencies that need linking. The following is a sample structure for our project.
Individual components from the component library are included in the implementation App's
package.json
as such:Some of our components depend on a native module that requires linking from the implementation App, such as
react-native-device-info
.When building the implementation App, it is evident that these transitive dependencies are not linked, as the generated
PackageList.java
does not include them - only those directly defined in the App'spackage.json
. I've looked at configuringreact-native.config.js
for each component, but was unable to find configuration that could assist with this kind of set up.The text was updated successfully, but these errors were encountered: