Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move fabric cpp files to ios folder #669

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Sep 29, 2022

Summary

closes #665

the cpp files will not be reused on android, since there the picker is not a ui component

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak changed the title fix: move ios fabric files to ios folder fix: move fabric cpp files to ios folder Sep 29, 2022
@vonovak vonovak marked this pull request as ready for review September 29, 2022 21:43
@vonovak vonovak enabled auto-merge (squash) September 29, 2022 21:45
@vonovak vonovak merged commit 033026c into master Sep 29, 2022
@vonovak vonovak deleted the fix/fabric-build branch September 29, 2022 21:49
vonovak pushed a commit that referenced this pull request Sep 29, 2022
## [6.4.1](v6.4.0...v6.4.1) (2022-09-29)

### Bug Fixes

* move ios fabric files to ios folder ([#669](#669)) ([033026c](033026c))
@vonovak
Copy link
Member Author

vonovak commented Sep 29, 2022

🎉 This issue has been resolved in version 6.4.1 🎉

If this package helps you, consider sponsoring us! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fabric] 'rndatetimepicker/ComponentDescriptors.h' file not found
1 participant