New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new arch support on android #730
Conversation
🎉 This issue has been resolved in version 7.0.0 🎉 If this package helps you, consider sponsoring us! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you reverted the name of the file to include .android.js
. It makes the codegen return wrong filenames and it does not compile on my machine with RN 0.70. Did you test it @vonovak ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I tested and e2e tests are passing - but with RN71. According to some comment I remember reading in discord, the .android
suffix should not cause issues even with RN 70 but if it does, it's best to drop it. Feel free to open a PR, otherwise I'll get to it sometime next week. thank you 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could check on a clean project, but if we want to support the RN 0.70 and there are cases where it fails, it seems fine to just change it.
Summary
this adds support for turbomodules on android
With this, the New Architecture is supported by this module
enabling the new architecture requires RN 0.71.4 or newer
if you don't use new arch I suppose RN 69 and newer is supported
Test Plan
Android e2e tests build and pass with new arch enabled
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md
example/App.js
)