Add missing countdown in RCT_ENUM_CONVERTE #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
merged commit c2d9a6e
into
react-native-datetimepicker:master
3 of 4 checks passed
|
thank you! 🙂 |
vonovak
pushed a commit
that referenced
this pull request
Aug 23, 2023
## [7.4.2](v7.4.1...v7.4.2) (2023-08-23) ### Bug Fixes * **ios:** add countdown to UIDatePickerMode converter ([#804](#804)) ([c2d9a6e](c2d9a6e))
|
🎉 This issue has been resolved in version 7.4.2 🎉 If this package helps you, consider sponsoring us! 🚀 |
|
@Nasseratic I see you've been responding to some issues here, appreciate it! Are you on discord? If you're interested, perhaps we could chat about if / how you can / want to help out with maintaining the library, ask questions and etc? 🙂 |
|
@vonovak Yes I am on Discord my username is |
|
@Nasseratic can you please check your discord? I sent you a friend request a week ago or so :) thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After upgrading react native to
0.72.3the countdown mode stopped working and was fallback to time mode. My guess is that react native changed howRCT_ENUM_CONVERTERworks.Adding
countdownto the enum fixed the issue.Test Plan
Try passing countdown to mode prop
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)