Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Release for Node 18.20 Memory Leak fix #219

Open
TiKevin83 opened this issue Apr 15, 2024 · 5 comments
Open

Bump Release for Node 18.20 Memory Leak fix #219

TiKevin83 opened this issue Apr 15, 2024 · 5 comments

Comments

@TiKevin83
Copy link
Contributor

We use this image for CI builds of React Native, can we bump out a release to use at least Node 18.20? I'm getting 18.19 in my CI pipeline and there's a critical fix in 18.20 for a memory leak in Jest tests that has been out there for 2.5 years and requiring running Jest with --workerIdleMemoryLimit set to a low number like 100mb to prevent OOMs in the CI runner.

jestjs/jest#11956
https://nodejs.org/en/blog/release/v18.20.0#vm-fix-v8-compilation-cache-support-for-vmscript

@TiKevin83 TiKevin83 changed the title Bump Release for Node 18.20 Bump Release for Node 18.20 Memory Leak fix Apr 15, 2024
@TiKevin83
Copy link
Contributor Author

@cortinico @tuncaulubilge are you able to rebuild and redeploy the image to get this resolved?

@cortinico
Copy link
Member

Please send a PR that bumps the Node version and if the CI is green we can merge it

@TiKevin83
Copy link
Contributor Author

Please send a PR that bumps the Node version and if the CI is green we can merge it

As far as I see the Node version is only specific to the major version 18, just I just go ahead and PR bumping it to the active LTS 20?

@cortinico
Copy link
Member

As far as I see the Node version is only specific to the major version 18, just I just go ahead and PR bumping it to the active LTS 20?

Nope we can't bump Node to 20 as of now.
We'll have to bump it to 18.20 and make sure that the download script keeps on working correctly.

@TiKevin83
Copy link
Contributor Author

Ok I see the N script should be able to handle 18.20 vs 18 - PRed here
#225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants