Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number.toLocaleString crashes #47

Closed
torkelrogstad opened this issue Jun 26, 2018 · 4 comments
Closed

Number.toLocaleString crashes #47

torkelrogstad opened this issue Jun 26, 2018 · 4 comments

Comments

@torkelrogstad
Copy link

torkelrogstad commented Jun 26, 2018

Issue Description

Calling Number.toLocaleString throws an error, Failed to format a number.

Version, config, any additional info

I'm running the jsc-android-intl variant of the prebuilt packages. Config file in my React Native are according to the documentation in this repo, except for android/app/build.gradle, where I had to use the following config to use the intl variant of the provided builds:

configurations.all {
    resolutionStrategy {
        eachDependency { DependencyResolveDetails details ->
            if (details.requested.name == 'android-jsc') {
                details.useTarget group: details.requested.group, name: 'android-jsc-intl', version: 'r224109'
            }
        }
    }
}

I found the config information above here. Any help greatly appreciated.

Originally I posted about this in #29 but I felt it was more appropriate to have a separate issue.

@torkelrogstad torkelrogstad changed the title String.toLocaleString crashes Number.toLocaleString crashes Jun 26, 2018
@Kmakinator
Copy link
Contributor

This is related to #36. This is problem with loading ICU locale data. I'm currently working on this issue for over a week. I will inform you when I finish

@DanielZlotin
Copy link
Collaborator

closing as duplicate of #36 , will update the README with the missing intl instructions

@ssuchanowski
Copy link

@Kmakinator any progress with this?

@deecewan
Copy link

@DanielZlotin is this the update you were referring to? b77d5e1#diff-04c6e90faac2675aa89e2176d2eec7d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants